On-demand plan fetch for bad actor findings (#604)#609
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 17, 2026
Merged
Conversation
Replaces the stored-plan-XML approach with live SQL Server fetches. Only queries that surface as high-impact findings get their plans analyzed — no storage overhead, no retention concerns. Architecture: - IPlanFetcher interface — platform-agnostic, both Lite and Dashboard can implement (Lite via ServerManager, Dashboard via DatabaseService) - SqlPlanFetcher — Lite implementation, fetches via sys.dm_exec_query_plan(plan_handle) on the monitored server - DrillDownCollector looks up plan_handle from DuckDB, then calls IPlanFetcher to get XML live, then runs PlanAnalyzer (30 rules) - Results include warnings and missing indexes with CREATE statements Only runs for BAD_ACTOR findings (1 plan per finding). Returns nothing if the plan has been evicted from cache (expected for completed queries). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IPlanFetcherinterface callssys.dm_exec_query_plan(plan_handle)on demandIPlanFetcherinterface for both Lite (SqlPlanFetcher) and future Dashboard portdrill_down.plan_analysisDesign
IPlanFetcher— interface withFetchPlanXmlAsync(serverId, planHandle)SqlPlanFetcher— Lite implementation usingServerManagerfor SQL connectionsDrillDownCollector— looks upplan_handlefrom DuckDB, fetches XML viaIPlanFetcher, runsPlanAnalyzerAnalysisService— accepts optionalIPlanFetcherparameter, passes toDrillDownCollectorLimitation
Plans must be in SQL Server's plan cache at analysis time. Evicted plans (completed/old queries) return nothing — this is expected behavior, not a bug.
Test plan
dotnet build— 0 errorsdotnet test— 138 tests passCloses #604
🤖 Generated with Claude Code