Fixed a bug with multiple pages. Added a Content tab.#32
Open
JeffreyVest wants to merge 1 commit intoericduran:gh-pagesfrom
Open
Fixed a bug with multiple pages. Added a Content tab.#32JeffreyVest wants to merge 1 commit intoericduran:gh-pagesfrom
JeffreyVest wants to merge 1 commit intoericduran:gh-pagesfrom
Conversation
Collaborator
|
this is awesome! can this been merged in? |
Collaborator
There was a problem hiding this comment.
contentText should probably be added here: https://github.com/ericduran/chromeHAR/blob/master/js/libs/HAREntry.js#L24
Collaborator
There was a problem hiding this comment.
why wrap a <pre> with a <p>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to add the content member for entries as another tab. Along the way I ran into a bug with it using the index of the entry within the page it was in, which doesn't work well when trying to pull entries on the second page and beyond. I changed it to instead just pass the entry directly.