fix(build): set explicit linux executableName for electron-builder 26#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
electron-builder 26 (merged in #39) added stricter validation of the Linux
executableName, which it derives from the package name@starcall/desktop→@starcalldesktop. The@is now rejected as an unsafe path character, failing the AppImage build:Windows/macOS were unaffected (they don't use that derived name). Fix sets an explicit
linux.executableName: starcallos. The user-facing AppImage filename is unchanged (still productName-based viaartifactName).Verification
workflow_dispatchrelease dry run on this branch — all three platforms green, including the Linux AppImage that previously failed; aggregate checksum job produced all six artifacts. Release-publish step correctly skipped (tag-gated).