Skip to content

Conversation

@dpatsora
Copy link
Contributor

snyk-top-banner

Snyk has created this PR to upgrade viem from 2.43.2 to 2.43.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.

  • The recommended version was released 25 days ago.

Release notes
Package name: viem from viem GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

@dpatsora dpatsora requested a review from a team as a code owner January 16, 2026 03:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dpatsora, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, updates the viem library to its latest patch version, 2.43.3. This routine maintenance ensures the project benefits from the latest bug fixes and minor enhancements, particularly those related to blockchain network configurations and transaction formatting within the viem ecosystem. The update also includes a related transitive dependency update for ox, contributing to overall dependency hygiene and stability.

Highlights

  • Dependency Upgrade: The viem library has been upgraded from version 2.43.2 to 2.43.3.
  • Transitive Dependency Update: The ox dependency, likely a transitive dependency of viem, has been updated from 0.10.6 to 0.11.1.
  • Viem Patch Changes: The viem update includes fixes for tempo formatter access keys, restoration of chain behavior in prepareTransactionRequest, and updates to tempo chain configuration. It also incorporates updates to Ox, fixes for JSON-RPC account formatting for Tempo transactions, and additions/updates for various network RPC URLs (Apollo mainnet, Moonbeam/Moonriver, HPP Mainnet & Sepolia, MANTRA DuKong).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the viem dependency from version 2.43.2 to 2.43.3. This is a patch release that includes bug fixes. I've reviewed the changes in viem and their potential impact on the codebase. The most notable change is the removal of the chain property from the request object returned by simulateContract. The current implementation appears to handle this correctly. However, this change highlights a potential risk in NitroliteService.ts where a type assertion to any is used, which could hide future type errors from viem updates. I've added a comment with a recommendation to address this for improved maintainability and robustness.

"dependencies": {
"abitype": "^1.2.3",
"viem": "^2.43.2",
"viem": "^2.43.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This patch upgrade of viem includes a change to the object returned by simulateContract. Specifically, the chain property is no longer part of the returned request object.

While the current implementation in sdk/src/client/services/NitroliteService.ts should handle this gracefully by relying on the walletClient's chain configuration, it highlights a potential risk with the use of as any in the executeWriteContract function (lines 39-42).

// sdk/src/client/services/NitroliteService.ts:39-42
return walletClient.writeContract({
    ...request,
    account,
} as any);

This type assertion suppresses type-checking, which means future breaking changes in viem might not be caught at compile time, leading to runtime errors.

I recommend creating a follow-up task to refactor this part and remove the as any cast. It might be possible to achieve type safety with more specific generic types or by creating a more constrained type for PreparedContractRequest instead of any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants