Deprecate resdata.util.test and set to remove in version 7.#1138
Merged
Conversation
eivindjahren
force-pushed
the
deprecate
branch
5 times, most recently
from
8af6ec4 to
6e1dee1
Compare
Also changes the deprecation message from plain warning to type warning. Note that some deprecation messages were not updated as there is no plan to remove in version 7. Also, monkey_the_camel methods now display deprecation warnings.
eivindjahren
force-pushed
the
deprecate
branch
6 times, most recently
from
276add5 to
b45867a
Compare
Because pytest does not like deprecation warnings at collect time, it was necessary to copy the classes into tests straight away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fix TestArea, it would be much simpler to apply some breaking changes: #1121 . We therefore deprecate
resdata.util.testswhich no one should really use, as all of its functionality is also in pytest/unittest, except potentially forSummaryMockwhich is not that great.Note that since pytest errors on deprecation warnings at collect time, it was necessary to copy in the parts of
resdata.util.testthat was used by the tests straight away.