Fix for GPU aware MPI#200
Closed
LudwigBoess wants to merge 1 commit into1.4.0rcfrom
Closed
Conversation
Collaborator
Author
|
For reference, this was the old issue: comparison.mov |
Collaborator
Author
|
Now it works, at least on Aurora. The impact on communication time is within the scatter of the nodes, I would say. This is with 8 nodes. |
Collaborator
Author
|
Replaced by #202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces explicit host copy with
Kokkos::fence()to fix GPU-aware MPI issues.This error appeared on Aurora, since they don't enforce that GPU operations are completed before the MPI call is invoked. For other MPI implementations, this seems to be the case. In these cases,
Kokkos::fence();should be a null operation at no overhead.ToDo: Check thoroughly on different systems/architectures.