Decompose IStorage tests and enhance coverage.#930
Merged
junkmd merged 10 commits intoenthought:mainfrom Feb 22, 2026
Merged
Conversation
- Extract `IStorage` constants and helper functions to global scope. - Break down `Test_IStorage` into test classes for each `IStorage` method.
- Convert `TODO` comments to proper Python comments for better readability.
- Add `STATFLAG_NONAME` constant. - Add test method to verify that `pwcsName` is `None` when `STATFLAG_NONAME` is used.
…exists. - Add `E_ACCESSDENIED` constant. - Add test method to verify that `IStorage.RenameElement` raises `E_ACCESSDENIED` when the destination name already exists.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
+ Coverage 88.47% 88.50% +0.03%
==========================================
Files 139 139
Lines 13575 13620 +45
==========================================
+ Hits 12010 12055 +45
Misses 1565 1565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors
test_storage.pyto improve test organization and expand coverage forIStoragemethods.The monolithic
Test_IStorageclass has been decomposed into smaller, more focused test classes, enhancing readability and maintainability.Additionally, new test cases specifically target error handling and edge cases for methods like
DestroyElement,RenameElement,Statflags, andSetStateBits.