Skip to content

Move npm publishing into build-and-publish #2218#2219

Merged
rymsha merged 1 commit into
masterfrom
move-npm-publish-to-action
Jul 1, 2026
Merged

Move npm publishing into build-and-publish #2218#2219
rymsha merged 1 commit into
masterfrom
move-npm-publish-to-action

Conversation

@rymsha

@rymsha rymsha commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Folds npm publishing into the shared build-and-publish action via npmPublish (enonic/release-tools#69), gated on build-and-publish.outputs.release.

  • build job: pass npmPublish: true.
  • Removed the Upload npm package step and the entire npm-publish job (the upload/download artifact shuffle only existed to move build/types between jobs).
  • Kept the GitHub release@master job.

Note: build/types is produced by the Gradle build (jar.dependsOn npmBuild); npmPublish rebuilds it before publishing (accepted per option 2).

Merge order: land enonic/release-tools#69 first.

Closes #2218

🤖 Generated with Claude Code

Use npmPublish on build-and-publish and drop the upload/download artifact
shuffle and the separate npm-publish job.

Closes #2218

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.85%. Comparing base (f976314) to head (628ae9f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2219   +/-   ##
=======================================
  Coverage   22.85%   22.85%           
=======================================
  Files           1        1           
  Lines          35       35           
=======================================
  Hits            8        8           
  Misses         27       27           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rymsha rymsha merged commit 5ca8882 into master Jul 1, 2026
5 checks passed
@rymsha rymsha deleted the move-npm-publish-to-action branch July 1, 2026 08:26
rymsha added a commit that referenced this pull request Jul 1, 2026
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
(cherry picked from commit 5ca8882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move npm publishing into build-and-publish (drop artifact shuffle)

1 participant