Skip to content

Long text overflows instead of wrapping in the TextArea #4546 #4547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skjulestad wants to merge 1 commit into from
Closed

Long text overflows instead of wrapping in the TextArea #4546 #4547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...main/resources/assets/admin/common/js/form2/components/occurrence-list/OccurrenceList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ const OccurrenceListRoot = <C extends InputTypeConfig = InputTypeConfig>({
: errors.validationResults;

return (
<div data-component={OCCURRENCE_LIST_NAME} className='grid gap-y-2'>
<div data-component={OCCURRENCE_LIST_NAME} className='grid min-w-0 gap-y-2'>
<InputLabel input={input} />
<Component
value={value}
Expand Down Expand Up @@ -260,7 +260,7 @@ const OccurrenceListRoot = <C extends InputTypeConfig = InputTypeConfig>({
const showRemove = state.canRemove && state.values.length > 1;

return (
<div data-component={OCCURRENCE_LIST_NAME} className='grid gap-y-2'>
<div data-component={OCCURRENCE_LIST_NAME} className='grid min-w-0 gap-y-2'>

@ashklianko ashklianko Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is only for single occurrence, you sure we need this here too?

@skjulestad skjulestad Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if not we keep min-w-auto default behavior.
Discovery: It might seem like textArea is wrapped in occurrence list even as a single component, to test make a new component text area input and inspect element.

<InputLabel input={input} />
<SortableGridList
items={state.values}
Expand Down Expand Up @@ -311,7 +311,7 @@ const OccurrenceListRoot = <C extends InputTypeConfig = InputTypeConfig>({
}

return (
<div data-component={OCCURRENCE_LIST_NAME} className='grid gap-y-2'>
<div data-component={OCCURRENCE_LIST_NAME} className='grid min-w-0 gap-y-2'>

@ashklianko ashklianko Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is only for single occurrence, you sure we need this here too?

@skjulestad skjulestad Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if not we keep min-w-auto default behavior.
Discovery: It might seem like textArea is wrapped in occurrence list even as a single component, to test make a new component text area input and inspect element.

<InputLabel input={input} />
<div className='flex flex-col gap-y-2.5'>
{state.values.map((_, i) => (
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/assets/admin/common/js/form2/components/text-area-input/TextAreaInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ export const TextAreaInput = ({
error={getFirstError(errors)}
maxLength={hasBoth ? undefined : maxLength}
endAddon={counterAddon}
className='min-w-0'
/>
);
};
Expand Down