Auth#1
Merged
Merged
Conversation
Review Summary by QodoRefine initial database schema and migrations
WalkthroughsDescription• Refined database schema with improved comments and structure • Made public_key optional for future E2EE implementation • Added soft delete support to messages table • Cleaned up migration file with clearer table documentation Diagramflowchart LR
users["users table<br/>with optional public_key"]
chats["chats table<br/>for conversations"]
participants["chat_participants<br/>many-to-many"]
messages["messages table<br/>with soft delete"]
indexes["performance indexes"]
users -- "references" --> participants
chats -- "references" --> participants
chats -- "references" --> messages
users -- "references" --> messages
messages -- "indexed by" --> indexes
File Changes1. migrations/20250521102510_initial_schema.sql
|
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| nonce BLOB NOT NULL, -- 12 bytes unique per message | ||
| tag BLOB NOT NULL, -- 16 bytes authentication tag | ||
| created_at TEXT NOT NULL DEFAULT (datetime('now')) | ||
| sender_id TEXT NOT NULL REFERENCES users(id) ON DELETE SET NULL, |
There was a problem hiding this comment.
1. Invalid fk delete action 🐞 Bug ≡ Correctness
messages.sender_id is declared NOT NULL but uses ON DELETE SET NULL, so deleting a referenced users row will fail with a constraint error when foreign keys are enforced. This makes user hard-deletes unreliable and the FK action effectively incorrect.
Agent Prompt
### Issue description
`messages.sender_id` is `NOT NULL` while the FK specifies `ON DELETE SET NULL`. SQLite will attempt to set `sender_id` to NULL on user deletion, which violates `NOT NULL` and aborts the delete.
### Issue Context
Foreign key enforcement is enabled in the application’s SQLite connection options, so this will surface as a runtime failure.
### Fix Focus Areas
- migrations/20260521102510_initial_schema.sql[28-37]
- src/db/mod.rs[4-8]
### Suggested fix
Pick one consistent behavior:
- If you want to preserve messages when a user is deleted: make `sender_id` nullable (remove `NOT NULL`) and keep `ON DELETE SET NULL`.
- If you never want user deletion to orphan messages: keep `NOT NULL` and change the FK action to `ON DELETE RESTRICT`/`NO ACTION` (or `CASCADE` if appropriate).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.