Skip to content

Add ExtraHeaders option to RegisterOptions #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rglonek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ExtraHeaders option to RegisterOptions #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions diago.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,10 @@ type RegisterOptions struct {
RetryInterval time.Duration
AllowHeaders []string

// extra headers to pass, will be added to REGISTER request
// for example: User-Agent: myuseragent/1.0
ExtraHeaders []sip.Header

// Useragent default will be used on what is provided as NewUA()
// UserAgent string
// UserAgentHostname string
Expand Down
5 changes: 5 additions & 0 deletions register_transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ func newRegisterTransaction(client *sipgo.Client, recipient sip.Uri, contact sip
if opts.ProxyHost != "" {
req.SetDestination(opts.ProxyHost)
}

for _, header := range opts.ExtraHeaders {
req.AppendHeader(header)
}

if expiry > 0 {
expires := sip.ExpiresHeader(expiry.Seconds())
req.AppendHeader(&expires)
Expand Down