Skip to content

Add OnRegisterStateChange callback for SIP registration lifecycle #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kjagosz wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

Add OnRegisterStateChange callback for SIP registration lifecycle #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion diago.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,13 +793,13 @@ func (dg *Diago) Register(ctx context.Context, recipient sip.Uri, opts RegisterO
}
}
}

if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
return err
}

t.expiry = retryAfter
}
return nil
}

// Register transaction creates register transaction object that can be used for Register Unregister requests
Expand Down
16 changes: 15 additions & 1 deletion register_transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ type RegisterOptions struct {
RetryInterval time.Duration
AllowHeaders []string

OnRegistered func()
OnRegistered func()
OnRegisterStateChange func(bool, error)

// Useragent default will be used on what is provided as NewUA()
// UserAgent string
Expand Down Expand Up @@ -96,12 +97,18 @@ func newRegisterTransaction(client *sipgo.Client, recipient sip.Uri, contact sip

func (t *RegisterTransaction) Register(ctx context.Context) error {
if err := t.register(ctx); err != nil {
if t.opts.OnRegisterStateChange != nil {
t.opts.OnRegisterStateChange(false, err)
}
return err
}

if t.opts.OnRegistered != nil {
t.opts.OnRegistered()
}
if t.opts.OnRegisterStateChange != nil {
t.opts.OnRegisterStateChange(true, nil)
}
return nil
}
func (t *RegisterTransaction) register(ctx context.Context) error {
Expand Down Expand Up @@ -187,7 +194,14 @@ func (t *RegisterTransaction) reregisterLoop(ctx context.Context, retry time.Dur
expiry := t.expiry
err := t.Qualify(ctx)
if err != nil {
if t.opts.OnRegisterStateChange != nil {
t.opts.OnRegisterStateChange(false, nil)
}
return err
} else {
if t.opts.OnRegisterStateChange != nil {
t.opts.OnRegisterStateChange(true, nil)
}
}

if t.expiry != expiry {
Expand Down