Merged
Conversation
20 tasks
69ebbfa to
0144c44
Compare
5cda8d9 to
a12c11f
Compare
jpenn2023
reviewed
Feb 25, 2026
a12c11f to
7dbfde7
Compare
jpenn2023
reviewed
Feb 27, 2026
jpenn2023
reviewed
Feb 27, 2026
0bc8e21 to
9d285ce
Compare
9d285ce to
ffffafe
Compare
jpenn2023
reviewed
Mar 27, 2026
Use the proper aggregated variable instead of the loop-local
* Add validator * Forbid string to tuple conversion
This is potentially only a temporary solution until we find a better design or figure out additional requirements. The class is private to simplify future refactorings.
Scienfitz
approved these changes
Apr 13, 2026
59418eb to
20f106b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevPR, parent is #745
parameter_namesICMKernelFactoryclass