add generic PDF object-tree writers for page and annotation dicts#561
Open
jchatkinson wants to merge 1 commit intoembedpdf:mainfrom
Open
add generic PDF object-tree writers for page and annotation dicts#561jchatkinson wants to merge 1 commit intoembedpdf:mainfrom
jchatkinson wants to merge 1 commit intoembedpdf:mainfrom
Conversation
|
@jchatkinson is attempting to deploy a commit to the OpenBook Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a generic serialized object-tree writer for unsupported PDF dictionary writes in EmbedPDF.
This PR introduces low-level write support for:
Motivation
This provides a low-level escape hatch for writing valid PDF spec fields that are not currently exposed by EmbedPDF’s typed APIs.
Examples this unlocks:
/VPviewport dictionaries/MeasurestructuresWhat Changed
@embedpdf/modelsPdfObjectSpecto describe serialized PDF object treessetPageDictValue(...)setAnnotationDictValue(...)@embedpdf/enginesPdfObjectSpecserialization for:nullbooleannumberstringnamearraydict@embedpdf/pdfium/ PDFiumEPDFPage_SetDictValue(...)EPDFAnnot_SetDictValue(...)CPDF_SyntaxParsernullas delete/remove for the target keyScope
This PR is limited to the generic write primitive.
It does not add:
/AP) authoringValidation
Validated with:
models,pdfium,engines, and downstream annotation packages-- Tested page /Rotate, adding /CL to freetext.
One important testing outcome:
Follow-up Work
Possible follow-ups after this primitive: