Enable ajv version 6 with json schema draft-06 support#6
Open
jpettit wants to merge 1 commit intoemanualjade:masterfrom
Open
Enable ajv version 6 with json schema draft-06 support#6jpettit wants to merge 1 commit intoemanualjade:masterfrom
jpettit wants to merge 1 commit intoemanualjade:masterfrom
Conversation
Author
|
@ehmicky - any reservation to upgrading to 6? |
Contributor
|
I think that's a great idea. We can actually even go to JSON schema v7. What works:
What does not work:
For the v4 to v7 and v7 to v4 conversions, I am unfortunately not aware any library currently does that (if you do, please let me know!), which probably means creating that first. I actually am quite familiar with JSON schema (I went through the spec many times) and I have a list of all the conversions required, but this needs to be implemented and unit tested. That's the main issue. By the way most JSON schema v7 can be expressed in JSON schema v4 (although much more verbosely). For example:
Actually the only JSON schema v7 property that (I think) cannot be converted to v4 is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying a
constvalue is only supported in json-schema 6. Updating the schema draft enables validation of the following response body like so in a task: