Add ability to set dashboard-banner-logo-title to a function.#85
Open
functionreturnfunction wants to merge 1 commit intoemacs-dashboard:masterfrom
Open
Add ability to set dashboard-banner-logo-title to a function.#85functionreturnfunction wants to merge 1 commit intoemacs-dashboard:masterfrom
functionreturnfunction wants to merge 1 commit intoemacs-dashboard:masterfrom
Conversation
Contributor
|
Hey @functionreturnfunction, could you show me a use-case for this? i would go for hooks being an idiom in the emacs community vs having callbacks for values that only set a string. |
Author
|
@rakanalh I'm using it to display start time/GC stats, and subsequently last refresh time, like so: 'after-init-time' can't be derived before dashboard is initialized, which is why OP in the post I linked adds 'dashboard-refresh-buffer' to 'after-init-hook' to refresh the dashboard a second time. That would be a bit expensive for me because I have some custom widgets. |
f7974e5 to
09d6f20
Compare
|
I really wanted a way to specify just a title, rather than a PNG logo. It looks like this would support that... what would need to be done to get this in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple callback functionality for the logo title; I had the idea when I read this post and decided against using hooks because one of my custom dashboard items is a little expensive to run so I don't want to run it twice.