Skip to content

fix: handle disposed scope during workflow instance refresh after Blazor disconnect #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −9
Draft

fix: handle disposed scope during workflow instance refresh after Blazor disconnect #770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6632b17
Initial plan
Copilot Mar 3, 2026
c6cad33
fix: stop activity refresh loop when circuit services are disposed
Copilot Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions ....Workflows/Components/WorkflowInstanceViewer/Components/WorkflowInstanceDesigner.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,17 +313,24 @@ private async Task UpdatePropertiesPaneHeightAsync()

private async Task RefreshSelectedItemAsync(string activityExecutionRecordId)
{
if (LastActivityExecution != null)
try
{
_activityExecutionRecordsLookup.Remove(LastActivityExecution.ActivityNodeId);
SelectedActivityExecutions = await GetActivityExecutionRecordsAsync(LastActivityExecution.ActivityNodeId);
}
if (LastActivityExecution != null)
{
_activityExecutionRecordsLookup.Remove(LastActivityExecution.ActivityNodeId);
SelectedActivityExecutions = await GetActivityExecutionRecordsAsync(LastActivityExecution.ActivityNodeId);
}

await InvokeAsync(() =>
await InvokeAsync(() =>
{
StateHasChanged();
_activityDetailsTab?.Refresh();
});
}
catch (ObjectDisposedException)
{
StateHasChanged();
_activityDetailsTab?.Refresh();
});
await StopRefreshActivityStatePeriodically();
}
}

private void RefreshActivityStatePeriodically(string activityExecutionRecordId)
Expand Down Expand Up @@ -419,4 +426,4 @@ async ValueTask IAsyncDisposable.DisposeAsync()
if (_refreshTimer != null)
await _refreshTimer.DisposeAsync();
}
}
}