Skip to content

feat: MCP support#417

Open
sdn4z wants to merge 1 commit intoelementsinteractive:mainfrom
sdn4z:mcp
Open

feat: MCP support#417
sdn4z wants to merge 1 commit intoelementsinteractive:mainfrom
sdn4z:mcp

Conversation

@sdn4z
Copy link
Collaborator

@sdn4z sdn4z commented Feb 27, 2026

Adding support for MCP
closes #418

@sdn4z
Copy link
Collaborator Author

sdn4z commented Feb 27, 2026

/lgtm review

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦉 lgtm Review

Score: Needs Work 🔧

🔍 Summary

This PR successfully introduces MCP support for twyn and refactors the CI workflows. The new MCP feature is a great addition.

However, there are two major issues that need to be addressed before this can be merged.

First, the refactoring of the CI/CD pipeline has removed the testing steps from the publish.yml workflow. This is a critical regression that could lead to publishing broken releases without any tests running on the release commit.

Second, the src/twyn/cli.py file has been refactored in a way that significantly reduces code quality. Several small, well-defined functions have been combined into a single, large run function, which is now difficult to read and maintain. It would be best to revert this specific change.

I've also noted a minor typo in the new MCP implementation.

Due to the critical nature of the CI changes and the reduction in code quality, I'm scoring this PR a 3/5. Please address these points.

More information
  • Id: d28fb6e296eb4ece91cb9a74b1227ea3
  • Model: gemini-2.5-pro
  • Created at: 2026-02-27T14:15:52.560075+00:00
Usage summary
  • Request count: 2
  • Request tokens: 71,938
  • Response tokens: 12,512
  • Total tokens: 84,450
Configuration
  • model: gemini-2.5-pro

  • model_url: None

  • technologies: ('Python',)

  • categories: ('Correctness', 'Quality', 'Testing', 'Security')

  • exclude: ('*.md', 'uv.lock', 'eval/classified_articles.py')

  • additional_context: ()

  • publish: True

  • output_format: pretty

  • silent: False

  • ai_retries: None

  • ai_input_tokens_limit: 500000

  • issues_url: None

  • issues_regex: (?:refs?|closes?|resolves?)[:\s]*((?:#\d+)|(?:#?[A-Z]+-\d+))|(?:fix|feat|docs|style|refactor|perf|test|build|ci)\((?:#(\d+)|#?([A-Z]+-\d+))\)!?:

  • issues_platform: None

  • compare: HEAD

See the 📚 lgtm-ai repository for more information about lgtm.

@github-actions github-actions bot added feature and removed feature labels Feb 27, 2026
@sdn4z sdn4z marked this pull request as ready for review February 27, 2026 14:53
@sdn4z sdn4z requested a review from scastlara as a code owner February 27, 2026 14:53
Copy link
Collaborator

@scastlara scastlara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure about all the changes to the CI 🤔 But leave that up to you.

The rest looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MCP support

2 participants