Bump to 9

[danirabbit]

Bump the library version so we can make breaking changes like building stylesheets by default

granite-7 has been pushed to granite-7 and deb-packaging-7 and recipes have been updated https://code.launchpad.net/~elementary-os/+recipe/granite-7-daily

[ryonakano]

Haven't tested yet but leaving some comments.

[danirabbit]

@ryonakano thanks for your attention to detail!

[ryonakano]

Sorry for my late re-review, I'll take another look today!

[danirabbit]

No worries! I'd like to get a couple of acks anyways :)

[ryonakano]

I got the following error when I apt-installed built .deb files with this PR and #950:

dpkg: error processing archive /home/user/work/libgranite-9-common_9.0.0_all.deb (--unpack):
 trying to overwrite '/usr/share/themes/Granite/gtk-4.0/gtk-dark.css', which is also in package libgranite-7-common 7.8.0+r28
95+pkg144~daily~ubuntu24.04.1

Full log:

user@elementary-test:~/work$ sudo apt install ./*.deb
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'gir1.2-granite-9.0' instead of './gir1.2-granite-9.0_9.0.0_arm64.deb'
Note, selecting 'granite-9-demo' instead of './granite-9-demo_9.0.0_arm64.deb'
Note, selecting 'libgranite-9-common' instead of './libgranite-9-common_9.0.0_all.deb'
Note, selecting 'libgranite-9-dev' instead of './libgranite-9-dev_9.0.0_arm64.deb'
Note, selecting 'libgranite9' instead of './libgranite9_9.0.0_arm64.deb'
The following NEW packages will be installed:
  gir1.2-granite-9.0 granite-9-demo libgranite-9-common libgranite-9-dev libgranite9
0 upgraded, 5 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/305 kB of archives.
After this operation, 1,937 kB of additional disk space will be used.
Get:1 /home/user/work/libgranite-9-common_9.0.0_all.deb libgranite-9-common all 9.0.0 [68.5 kB]
Get:2 /home/user/work/libgranite9_9.0.0_arm64.deb libgranite9 arm64 9.0.0 [141 kB]
Get:3 /home/user/work/gir1.2-granite-9.0_9.0.0_arm64.deb gir1.2-granite-9.0 arm64 9.0.0 [18.3 kB]
Get:4 /home/user/work/granite-9-demo_9.0.0_arm64.deb granite-9-demo arm64 9.0.0 [51.6 kB]
Get:5 /home/user/work/libgranite-9-dev_9.0.0_arm64.deb libgranite-9-dev arm64 9.0.0 [25.7 kB]
(Reading database ... 183441 files and directories currently installed.)
Preparing to unpack .../libgranite-9-common_9.0.0_all.deb ...
Unpacking libgranite-9-common (9.0.0) ...
dpkg: error processing archive /home/user/work/libgranite-9-common_9.0.0_all.deb (--unpack):
 trying to overwrite '/usr/share/themes/Granite/gtk-4.0/gtk-dark.css', which is also in package libgranite-7-common 7.8.0+r28
95+pkg144~daily~ubuntu24.04.1
Selecting previously unselected package libgranite9:arm64.
Preparing to unpack .../libgranite9_9.0.0_arm64.deb ...
Unpacking libgranite9:arm64 (9.0.0) ...
Selecting previously unselected package gir1.2-granite-9.0.
Preparing to unpack .../gir1.2-granite-9.0_9.0.0_arm64.deb ...
Unpacking gir1.2-granite-9.0 (9.0.0) ...
Selecting previously unselected package granite-9-demo.
Preparing to unpack .../granite-9-demo_9.0.0_arm64.deb ...
Unpacking granite-9-demo (9.0.0) ...
Selecting previously unselected package libgranite-9-dev.
Preparing to unpack .../libgranite-9-dev_9.0.0_arm64.deb ...
Unpacking libgranite-9-dev (9.0.0) ...
Errors were encountered while processing:
 /home/user/work/libgranite-9-common_9.0.0_all.deb
N: Download is performed unsandboxed as root as file '/home/user/work/libgranite-9-common_9.0.0_all.deb' couldn't be accessed by user '_apt'. - pkgAcquire::Run (13: Permission denied)
E: Sub-process /usr/bin/dpkg returned an error code (1)
user@elementary-test:~/work$

[ryonakano]

Granite 7 just uses gtk-stylesheets option only to define INCLUDE_GTK_STYLESHEETS and GTK stylesheets seem to be always built and installed. Probably we need to fix this first, merge it to main and granite-7 branches, and then build Granite 7 on Launchpad first?

[danirabbit]

Ah yup, good catch!

[ryonakano]

Granite 7 just uses gtk-stylesheets option only to define INCLUDE_GTK_STYLESHEETS and GTK stylesheets seem to be always built and installed. Probably we need to fix this first, merge it to main and granite-7 branches, and then build Granite 7 on Launchpad first?

I merged the recent changes into granite-7 and deb-packaging-7 branches and triggered build on Launchapd. Waiting for being published to daily PPA.

https://code.launchpad.net/~elementary-os/+recipe/granite-7-daily

[ryonakano]

LGTM as I wrote in #950 (review)

[ryonakano]

Leaving opening these two PRs in case someone in @elementary/desktop-developers review.

[danirabbit]

Gonna convert this to draft real quick so it doesn't get merged before we release Granite 7.8.1 to avoid that package collision