Skip to content

Conversation

@lenemter
Copy link
Member

Third time's a charm

Rename .vert shaders to .frag because well, these are fragment shaders, not vertex shaders.

Fixes the strange offsets in shader code by correctly calculating offsets using clutter_actor_box_enlarge_for_effects which is mutter private api. This works with and without fractional scaling which was the flaw of my previous attempts

@lenemter lenemter mentioned this pull request Nov 20, 2025
5 tasks
@danirabbit danirabbit requested a review from a team November 21, 2025 17:01
@lenemter lenemter requested a review from leolost2605 November 26, 2025 13:45
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corners look a lot better already but I'm still noticing another thing. On main with scale of 1.5 it looks like this

Image

which has a corner radius of 5 pixels (if you ignore the semi transparent additional pixel btw is this intended?) which make sense being 3 * 1.5 rounded up.

With this branch however it has a corner radius of 4? Is that intended? It looks a lot less round in practice

Image

Btw I don't know much about corner radii and where you start counting them etc. so correct me if I'm wrong somewhere I just noticed the difference here :)

Also is there a specific issue this branch fixes so that I can check that?

@danirabbit danirabbit added this to OS 9 Dec 3, 2025
@danirabbit danirabbit moved this to In progress in OS 9 Dec 3, 2025
@danirabbit danirabbit removed this from OS 9 Dec 7, 2025
@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Dec 7, 2025
@lenemter
Copy link
Member Author

@leolost2605 Gtk4 tooltips seem to have the same issue, so I guess 4px is intended..?

image

@leolost2605
Copy link
Member

leolost2605 commented Dec 27, 2025

@leolost2605 Gtk4 tooltips seem to have the same issue, so I guess 4px is intended..?

Ah all right that's good to know but IMO it looks better there because on both sides it is fully opaque whereas in the screenshot from this branch only one side is really opaque and the other quite transparent.

Also another thing I noticed is that there are different corners on the top and bottom (this is at 1.25x scaling):

image

I don't know, if you prefer we can merge this for now and then continue fine tuning later since it is very self contained.
But can we maybe split out the file renaming to a separate commit/PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

4 participants