Skip to content

Don't make ItemManager a singleton#551

Open
leolost2605 wants to merge 2 commits intomainfrom
leolost/dont-make-item-manager-singleton
Open

Don't make ItemManager a singleton#551
leolost2605 wants to merge 2 commits intomainfrom
leolost/dont-make-item-manager-singleton

Conversation

@leolost2605
Copy link
Member

No description provided.

@leolost2605 leolost2605 requested a review from a team December 25, 2025 23:58
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me, though I am not sure if there should be any null checks or why it should not a singleton since I am not familiar with the dock code base as much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants