Pass key in custom converter function -- updated#16
Open
toddallen97 wants to merge 3 commits intoelectricimp:developfrom
Open
Pass key in custom converter function -- updated#16toddallen97 wants to merge 3 commits intoelectricimp:developfrom
toddallen97 wants to merge 3 commits intoelectricimp:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the modifications made in PR #7 to work with the ability to convert data not in a structure (PR #14).
I have:
@betzrhodes I am aware that
getinfossupport is in the works, but with the version control system in place, users can#requirethe 1.0.2 release or the 2.0.0 release with this feature, that way the change doesn't need to break existing code.I hope this helps address some of the blockers!