feat: expose page metrics via rich events !!#1003
Open
shahzad31 wants to merge 1 commit into
Open
Conversation
vigneshshanmugam
left a comment
vigneshshanmugam
left a comment
Member
There was a problem hiding this comment.
I am not against exposing this information, but the current API is not well thoughtout and currently lacks the page information where the metrics was gathered, so if a step has multiple pages, popups, iframes etc, the metric would be incorrect. We need to come up with a valid design for the Kibana UI and expose the page specific metric information along with step/url information etc. Please let me know if you have some other ideas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expose page metrics via rich events !!