-
Notifications
You must be signed in to change notification settings - Fork 860
[Icons] Icons renaming batch #9279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
💚 Build SucceededHistory
|
💚 Build Succeeded
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have:
chevron_limit_left.tsxchevron_limitLeft.tsxchevronLimitLeft.tsx
is this expected? Shouldn't it be just chevron_limit_left.tsx and chevronLimitLeft.tsx?
| arrowStart: 'arrowStart', | ||
| arrowEnd: 'arrowEnd', | ||
| arrowDown: 'chevron_single_down', // NOTE: To be deprecated in favor of chevronSingleDown | ||
| chevronSingleDown: 'chevron_single_down', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely love the change from arrow to chevron ❤️
|
It could be worth looking at #9275 (that's where the snapshot conflicts are coming from). Is this the naming we'd like for it? |
Summary
Renaming batch of icons EUI icons, creating aliases with the previous names for each one in order to support the consumption using the old name references. Also fixing the wrong naming convention for some svgs using camel case instead of snake case.
Why are we making this change?
As a part of the new Borealis visual refresh @MichaelMarcialis reviewed also the naming conventions and with the goal of make easier the process for searching icons and simplify the meaning of all of them there were many naming changes proposed into this list
Related ticket: https://github.com/elastic/platform-ux-team/issues/953
Detail of the changes done
We spotted a few conflicting renaming issues that are not tackled in this PR and will be done in a separated PR. More details below:
Details
ELASTIC UI ICON RENAME SPECIFICATIONS
Extracted from Figma Icon Inventory (Phases 1-7)
Date: December 17, 2025
5 NAMING CONFLICTS REQUIRE RESOLUTION BEFORE IMPLEMENTATION
Conflict 1: arrowDown
Phase 1: arrowDown → chevronSingleDown
Phase 2: sortDown → arrowDown
❌ Result: current sortDown and arrowDown will swap the glyphs
Conflict 2: arrowLeft
Phase 1: arrowLeft → chevronSingleLeft
Phase 2: sortLeft → arrowLeft
❌ Result: current sortLeft and arrowLeft will swap the glyphs
Conflict 3: arrowRight
Phase 1: arrowRight → chevronSingleRight
Phase 2: sortRight → arrowRight
❌ Result: current sortRight and arrowRight will swap the glyphs
Conflict 4: arrowUp
Phase 1: arrowUp → chevronSingleUp
Phase 2: sortUp → arrowUp
❌ Result: current sortUp and arrowUp will swap the glyphs
Conflict 5: invert
Phase 3: merge → invert
Phase 5: invert → contrast
❌ Result: current merge and invert will swap the glyphs
RESOLUTION STRATEGIES
Make only these changes for conflicting names:
Phase 1: arrowDown → chevronSingleDown
Phase 1: arrowLeft → chevronSingleLeft
Phase 1: arrowRight → chevronSingleRight
Phase 1: arrowUp → chevronSingleUp
Pause the renaming and find a new name proposal for currents
sortDown,sortUp,sortLeftandsortRightPause the renaming and find an alternative for the current
mergeandinverticonsSUMMARY
Total Phases Processed: 7
Total Rename Specifications: 135
PHASE 1: RENAME SPECIFICATIONS (17 items)
PHASE 2: RENAME SPECIFICATIONS (22 items)
sortRight → arrowRightsortLeft → arrowLeftsortUp → arrowUpsortDown → arrowDownPHASE 3: RENAME SPECIFICATIONS (18 items)
merge → invertPHASE 4: RENAME SPECIFICATIONS (21 items)
PHASE 5: RENAME SPECIFICATIONS (18 items)
invert → contrastPHASE 6: RENAME SPECIFICATIONS (25 items)
PHASE 7: RENAME SPECIFICATIONS (14 items)
Impact to users
All the renamed icons have a new alias pointing out to the new references, so that it shouldn't have an impact on final users. The new aliases to be deprecated are signposted with a comment into the
icon_map.tsfile. These deprecations might me tackled in another PR and will have an impact in Kibana users.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles