[Data Grid] Account for text being selected when cell scrolls into view #9276
+51
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acstll
added
skip-changelog
this ensures the interaction is reliable, since scrolling will only happen after the pointer is up
acstll
removed
the
skip-changelog
mgadewoll
reviewed
Dec 19, 2025
Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
Collaborator
💚 Build SucceededHistory
cc @acstll |
Collaborator
💚 Build Succeeded
History
cc @acstll |
mgadewoll
reviewed
Dec 19, 2025
| useEffect(() => { | ||
| if (focusedCell) { | ||
| // do not scroll if text is being selected | ||
| if (isPointerDown || window?.getSelection()?.type === 'Range') { |
Contributor
There was a problem hiding this comment.
Now that I think about it: Should we add some tests for this to verify scrolling doesn't happen in this case?
Contributor
Author
There was a problem hiding this comment.
aha! it wouldn't hurt, let me give it a try!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to elastic/kibana#245368
In
EuiDataGrid, when you click e.g. focus on a cell that is not fully visible, it will instantly scroll fully into view. Both axis. If you try to select text on a cell that is not fully visible, the scrolling will block you from making the selection.This PR adds a small check for the text selection use case, right before doing the automatic scroll.
Let's tests this to see if it makes sense.It's been manually tested and fulfills the request in elastic/kibana#245368Why are we making this change?
It's a papercut kind of fix. It improves UX.
Screenshots
Before
Check the clip in elastic/kibana#245368
After
Clip
Impact to users
🟢 None. No API or type changes.
QA
General checklist
@defaultif default values are missing) and playground toggles