WIP - Add Exception Duplication Checking#5689
Draft
eric-forte-elastic wants to merge 1 commit intomainfrom
Draft
WIP - Add Exception Duplication Checking#5689eric-forte-elastic wants to merge 1 commit intomainfrom
eric-forte-elastic wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Resolves: #5664
Summary - What I changed
Note
It is unclear and needs to be determined if item_ids are unique across spaces and can function as an identifier similarly to list_ids
1. New helper:
_deduplicate_comments()commentslist that keeps only the first occurrence of each comment (using aseen_textsset).commentsreplaced by the deduplicated list; the original is not mutated.2. Changes to
parse_exceptions_results_from_api()item_id:seen_item_ids: set[str]to track already-seen exception item IDs.item_idand that ID is already inseen_item_ids, the result is skipped (duplicate).item_id, that ID is added toseen_item_ids._deduplicate_comments(result)and appends the returned item instead of the rawresult.Result
item_id) are dropped before building TOML.How To Test
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist