Fix for specific time scheduled crawls skipping if too many crawlers#597
Merged
mattnowzari merged 7 commits intomainfrom Jan 10, 2025
Merged
Fix for specific time scheduled crawls skipping if too many crawlers#597mattnowzari merged 7 commits intomainfrom
mattnowzari merged 7 commits intomainfrom
Conversation
…nc_triggered? and custom_sync_triggered?
…w() calls in Timecop.freeze() + fixed minor typo in :monthly_interval cron schedule
Contributor
navarone-feekery
left a comment
navarone-feekery
left a comment
There was a problem hiding this comment.
Looking good! Just left a few possible test cases that could be covered.
Member
|
Nit: your PR title is |
…s skipped + added an expect() to an existing test to check if debug logs are presented there as well + revised debug log wording to include the poll_interval value
…he correct messages + moved those expect() lines out of the before(:each) blocks and into it blocks
💔 Failed to create backport PR(s)
To backport manually run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for specific time scheduled crawls being skipped if too many crawlers exist.
See 'Related Pull Requests' below for the work to introduce a configurable poll_interval value in ent-search.
Great explanation by @navarone-feekery here that includes an RCA, how to reproduce, and three solutions to tackle this problem, two of which are addressed in this PR.
Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)Changes Requiring Extra Attention
Related Pull Requests
https://github.com/elastic/ent-search/pull/8256
Release Note
For Elastic Internal Use Only
connectors_utilityandconnectors_service) and included into Enterprise Search and tested that Enterprise Search works well with new gem versions. Instruction can be found here