@ekino/config 2.0 #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
TODO: fix github-action for release and changelog. |
Nico385412
reviewed
Nov 26, 2025
.github/workflows/ci.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] |
There was a problem hiding this comment.
Suggested change
| node-version: [18.x, 20.x, 22.x] | |
| node-version: [20.x, 22.x, 24.x] |
Author
There was a problem hiding this comment.
Yeah, it’s been quite a long time since this PR was created.
.github/workflows/release.yml
Outdated
| release: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-24.04 | ||
| if: ${{ github.actor == 'pebie' || github.actor == 'leguellec' }} |
Author
There was a problem hiding this comment.
I took the idea from other projects like veggies and node-logger. But now I’ve set it up for all maintainers and admins, not just Mika or Julos.
.github/workflows/release.yml
Outdated
| version: 10 | ||
| run_install: false | ||
|
|
||
| - name: Setup Node.js 22.x |
There was a problem hiding this comment.
Suggested change
| - name: Setup Node.js 22.x | |
| - name: Setup Node.js 24.x |
.github/workflows/release.yml
Outdated
| - name: Setup Node.js 22.x | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22.x' |
There was a problem hiding this comment.
Suggested change
| node-version: '22.x' | |
| node-version: '24.x' |
CONTRIBUTING.md
Outdated
|
|
||
| ## How to contribute | ||
|
|
||
| Follow this guide to ensure a smooth contribution process. If you're planning significant work or substantial changes, please create an issue labeled "contribution enquiry" to discuss your proposal. This will help ensure that your work aligns with the project's goals. |
There was a problem hiding this comment.
- The label does not exist
- New comers cannot add labels themself
Author
There was a problem hiding this comment.
Yes, same issues like node-logger. Thank @Nico385412. Done!
Nico385412
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrite @ekino/config for v2.0
Motivation
What has changed?
Here are the key changes made in this PR:
Test plan
Also close issue #40