Skip to content

Polish unit tests for refactored Callback#4

Merged
ekapadi merged 3 commits into
EWM16074_live_data_memory_leakfrom
copilot/complete-unit-test-coverage
Apr 28, 2026
Merged

Polish unit tests for refactored Callback#4
ekapadi merged 3 commits into
EWM16074_live_data_memory_leakfrom
copilot/complete-unit-test-coverage

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 28, 2026

⚠️ Action needed: This PR was opened against the default branch by mistake. The branch HEAD has been shaped so that its diff vs EWM16074_live_data_memory_leak is only the test-file changes (62 insertions / 46 deletions in tests/unit/meta/test_Callback.py). Please retarget the PR base from the default branch to EWM16074_live_data_memory_leak via the GitHub UI ("Edit" next to the title → change base branch). After retargeting, the diff will show only the intended test changes.

  • Sync src/snapred/meta/Callback.py with the EWM16074_live_data_memory_leak base branch
  • Refactor test_callback_instancestest_callbackInstances: remove print statements, drop docstring and verbose assertion messages
  • Add tests covering remaining new behavior: container forwarding (__len__/__getitem__/__contains__/__iter__), __setitem__ forwarding, __setattr__ forwarding to wrapped value, and forwarded magic-method errors when unset
  • Run unit tests for tests/unit/meta/test_Callback.py (12 passed) and ruff check (clean)
  • Merge EWM16074_live_data_memory_leak into branch so it can be retargeted as the PR base
  • User action: retarget PR Polish unit tests for refactored Callback #4 base to EWM16074_live_data_memory_leak

…nit-test-coverage

# Conflicts:
#	tests/unit/meta/test_Callback.py

Co-authored-by: ekapadi <5505178+ekapadi@users.noreply.github.com>
@ekapadi ekapadi changed the base branch from next to EWM16074_live_data_memory_leak April 28, 2026 09:06
@ekapadi ekapadi marked this pull request as ready for review April 28, 2026 09:23
@ekapadi ekapadi merged commit 5c74e6d into EWM16074_live_data_memory_leak Apr 28, 2026
1 check passed
@ekapadi ekapadi deleted the copilot/complete-unit-test-coverage branch April 28, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants