Skip to content

Conversation

@aosen-xiong
Copy link
Member

No description provided.

@aosen-xiong
Copy link
Member Author

Is this typo intentional then?

@wmdietl
Copy link
Member

wmdietl commented Sep 3, 2025

Thanks for finding this! I wouldn't call this a typo - it passes an illegal argument to an option.
Can you see what the original intent of the test was and how we can fix this overall?
We should also be more stringent about validating options and fail if an illegal argument is passed. Please open an issue for that.

@aosen-xiong aosen-xiong marked this pull request as draft September 3, 2025 15:56
@aosen-xiong
Copy link
Member Author

Thanks for finding this! I wouldn't call this a typo - it passes an illegal argument to an option. Can you see what the original intent of the test was and how we can fix this overall? We should also be more stringent about validating options and fail if an illegal argument is passed. Please open an issue for that.

Looks like you already noticed this a few years back. Seehttps://github.com/typetools/checker-framework/pull/1318#discussion_r217824677.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants