Mismatched checker-qual artifact example
#1318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is for #1243 subtask. |
wmdietl
requested changes
Jul 6, 2025
Member
wmdietl
left a comment
wmdietl
left a comment
There was a problem hiding this comment.
Thanks for starting this!
Please add #1243 to the changelog.
To fix the misc failure, follow the steps from the error message:
+ git diff --exit-code docs/manual/contributors.tex
diff --git a/docs/manual/contributors.tex b/docs/manual/contributors.tex
index 8852dac7f..579eabdc2 100644
--- a/docs/manual/contributors.tex
+++ b/docs/manual/contributors.tex
@@ -1,6 +1,7 @@
Abraham Lin,
Adian Qian,
Aditya Singh,
+Ahnaf Shahriar,
Akash Srivastava,
Alex Cook,
Alex Liu,
+ set +x
docs/manual/contributors.tex is not up to date.
If the above suggestion is appropriate, run: make -C docs/manual contributors.tex
If the suggestion contains a username rather than a human name, then do all the following:
* Update your git configuration by running: git config --global user.name "YOURFULLNAME"
* Add your name to your GitHub account profile at https://github.com/settings/profile
* Make a pull request to add your GitHub ID to
https://github.com/eisop-plume-lib/git-scripts/blob/master/git-authors.sed
and remake contributors.tex after that pull request is merged.
Co-authored-by: Werner Dietl <wdietl@gmail.com>
…ualifiers instead of dependencies
wmdietl
changed the title
checker-qual artifact example
wmdietl
requested changes
Sep 1, 2025
| docs/examples/errorprone/.gradle/ | ||
| docs/examples/errorprone/Out.txt | ||
| docs/examples/nullaway/.gradle/ | ||
| docs/examples/Wrong-Checker-Qual/Out.txt |
Member
There was a problem hiding this comment.
Suggested change
| docs/examples/Wrong-Checker-Qual/Out.txt | |
| docs/examples/mismatched-checker-qual/Out.txt |
| $(MAKE) -C BazelExample clean | ||
| $(MAKE) -C nullaway clean | ||
| $(MAKE) -C jspecify clean | ||
| $(MAKE) -C mismatched-checker-qual clean |
Member
There was a problem hiding this comment.
Suggested change
| $(MAKE) -C mismatched-checker-qual clean | |
| $(MAKE) -C mismatched-checker-qual clean |
| 'org.checkerframework.checker.nullness.NullnessChecker', | ||
| ] | ||
| extraJavacArgs = ['-Aversion'] | ||
| } No newline at end of file |
|
|
||
| .PHONY: all clean | ||
|
|
||
| ifeq ($(shell test $(JAVA_VER) -lt 17; echo $$?),0) |
Member
There was a problem hiding this comment.
This test isn't using errorprone, so this can be simplified.
| else | ||
| all: | ||
| - ../../../gradlew build > Out.txt 2>&1 | ||
| # Check for crash due to mismatched Checker Qualifiers |
Member
There was a problem hiding this comment.
Add a TODO, here or somewhere else, that explains that we would want more graceful behavior.
|
|
||
| ext { | ||
| versions = [ | ||
| eisopVersion: '3.49.3-eisop1', |
Member
There was a problem hiding this comment.
Suggested change
| eisopVersion: '3.49.3-eisop1', | |
| eisopVersion: '3.49.3-eisop1', | |
| typetoolsVersion: '3.49.1', |
Comment on lines
+24
to
+25
| compileOnly "org.checkerframework:checker-qual:3.49.1" | ||
| testCompileOnly "org.checkerframework:checker-qual:3.49.1" |
Member
There was a problem hiding this comment.
Suggested change
| compileOnly "org.checkerframework:checker-qual:3.49.1" | |
| testCompileOnly "org.checkerframework:checker-qual:3.49.1" | |
| compileOnly "org.checkerframework:checker-qual:${versions.typetoolsVersion}" | |
| testCompileOnly "org.checkerframework:checker-qual:${versions.typetoolsVersion}" |
| apply plugin: 'org.checkerframework' | ||
|
|
||
| dependencies { | ||
| // Without the same checker qualifiers, Nullness Checker should gracefully issue warnings |
Member
There was a problem hiding this comment.
Move this to the beginning of the file, where it is currently not clear what the intended behavior is.
|
|
||
| dependencies { | ||
| // Without the same checker qualifiers, Nullness Checker should gracefully issue warnings | ||
| // Use Typetools checker-qual (original) for qualifiers |
Member
There was a problem hiding this comment.
Suggested change
| // Use Typetools checker-qual (original) for qualifiers | |
| // Mismatch between `checker-qual` and `checker` artifacts. |
|
|
||
| public class Demo { | ||
| void demo(Set<Short> s, short i) { | ||
| s.remove(i - 1); // Error Prone error |
Member
There was a problem hiding this comment.
This test doesn't use errorprone, so we can simplify this. Keep just a Nullness Checker example, for which we can test once the "graceful" behavior is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1107 creating an example to recreate the crash. Copied from ErrorProne example. Using for test validation of the subpackage graceful handling in the case of a mismatch.
Fixes #1243