Skip to content

fix: ensure spack env exists before activation #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plexoos wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: ensure spack env exists before activation #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
060d525
fix: ensure spack env exists before activation
plexoos Oct 9, 2025
a8bea17
Merge branch 'master' into fix-env
veprbl Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions containers/eic/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ ENV GIT_TERMINAL_PROMPT=0
# Concretization (default environment)
RUN <<EOF
set -e
spack env create ${ENV}
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line creates a new named environment "xl" in spack's default location, but the next line activates a directory-based environment at ${SPACK_ENV} (/opt/spack-environment/xl). These are two different environments. The directory already contains a spack.yaml file (copied at line 44), so it can be activated directly without creating a new environment. Other similar usages in this file (lines 178, 283, 322) activate the directory environment without calling 'spack env create' first. This line should be removed.

Suggested change
spack env create ${ENV}

Copilot uses AI. Check for mistakes.
spack env activate --without-view --dir ${SPACK_ENV}
spack external find --not-buildable --scope env:${SPACK_ENV} --path /usr/local/cuda/bin cuda
spack external find --scope env:${SPACK_ENV} llvm
Expand Down