fix: avoid finding externals in all environments by doing it in base #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the Docker build process by consolidating external package discovery into the base image rather than repeating it in each environment build. This reduces redundant operations and improves build efficiency.
- Removes
spack external findcommands from the EIC environment Dockerfile - Adds centralized external package discovery in the Debian base image with site-level scope
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| containers/eic/Dockerfile | Removes environment-specific external package finding for CUDA and LLVM (2 lines removed) |
| containers/debian/Dockerfile | Adds base image external package discovery for LLVM, GCC, and CUDA with site-level scope (9 lines added including comments) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as resolved.
This comment was marked as resolved.
wdconinc
force-pushed
the
externals-in-base
branch
from
def7e56 to
1de78a5
Compare
veprbl
approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR moves the finding of externals from every environment build into the base image build.