build: sync jsr.jsonc version with package.json#674
Open
antongolub wants to merge 1 commit intoeemeli:mainfrom
Open
build: sync jsr.jsonc version with package.json#674antongolub wants to merge 1 commit intoeemeli:mainfrom
antongolub wants to merge 1 commit intoeemeli:mainfrom
Conversation
eemeli
requested changes
Mar 21, 2026
Owner
eemeli
left a comment
eemeli
left a comment
There was a problem hiding this comment.
This looks great; I'd not considered this approach to ensuring that the JSR version is kept up to date.
If/as it makes sense to update the jsr.jsonc "version" value like this, the in-repo value of the jsr.jsonc "version" to be set to something that was clearly not the current version, and easier to search/replace for.
| - uses: actions/checkout@v4 | ||
| - name: Sync version to jsr.jsonc | ||
| run: | | ||
| node -e " |
Owner
There was a problem hiding this comment.
Using ' single quotes outside and " double quotes inside would be clearer, and help ensure that ` or $ characters aren't assigned a bash meaning.
Comment on lines
+27
to
+28
| /(\"version\"\s*:\s*\")([^\"]+)(\")/, | ||
| \`$1\${pkgVersion}$3\` |
Owner
There was a problem hiding this comment.
A lookbehind assertion would simplify things here.
Suggested change
| /(\"version\"\s*:\s*\")([^\"]+)(\")/, | |
| \`$1\${pkgVersion}$3\` | |
| /(?<="version"\s*:\s*")[^\"]+/, | |
| pkgVersion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #672