Make read_json_value handle "true" and "false"#12
Open
ziggythehamster wants to merge 1 commit intoeee-c:masterfrom
Open
Make read_json_value handle "true" and "false"#12ziggythehamster wants to merge 1 commit intoeee-c:masterfrom
ziggythehamster wants to merge 1 commit intoeee-c:masterfrom
Conversation
When I was attempting to push my docs back to CouchDB, I found that some of my design documents had certain properties serialized as literally "false" or "true". I don't necessarily disagree with that, but then the JSON parser complains. So this makes it return false or true when that's all in the file, which makes my docs import as expected. If there's a cleaner way to fix this, please let me know and I'll submit a better patch :)
Owner
|
Thanks for the PR! Can you make sure that the specs still pass? I'll try to have a look myself when I get a chance... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was attempting to push my docs back to CouchDB, I found that
some of my design documents had certain properties serialized as
literally "false" or "true". I don't necessarily disagree with that,
but then the JSON parser complains. So this makes it return false or
true when that's all in the file, which makes my docs import as
expected.
If there's a cleaner way to fix this, please let me know and I'll
submit a better patch :)