Chore: rever to old enterprise.catalog.app name to sync with other configs #189
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the enterprise catalog service container name and URL references back to enterprise.catalog.app from edx.devstack.enterprise-catalog to maintain consistency with other configuration files across the codebase.
Key Changes:
- Updated container name in docker-compose.yml from
edx.devstack.enterprise-catalogtoenterprise.catalog.app - Updated ENTERPRISE_CATALOG_URL references in three Python configuration files to use the
enterprise.catalog.apphostname
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docker-compose.yml | Reverts enterprise-catalog container name to enterprise.catalog.app |
| py_configuration_files/license_manager.py | Updates ENTERPRISE_CATALOG_URL to use enterprise.catalog.app hostname |
| py_configuration_files/enterprise_subsidy.py | Updates ENTERPRISE_CATALOG_URL to use enterprise.catalog.app hostname |
| py_configuration_files/enterprise_access.py | Updates ENTERPRISE_CATALOG_URL to use enterprise.catalog.app hostname |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| ENTERPRISE_LEARNER_PORTAL_BASE_URL = 'http://localhost:8734' | ||
| ENTERPRISE_CATALOG_URL = 'http://edx.devstack.enterprise-catalog:18160' | ||
| ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160' |
There was a problem hiding this comment.
The hostname enterprise.catalog.app in the URL does not match the container name enterprise.catalog.app from docker-compose.yml, which uses hostname enterprise-catalog.devstack.edx (line 746). This mismatch will cause connection failures. The URL should use http://enterprise-catalog.devstack.edx:18160 to match the actual hostname, or the hostname in docker-compose.yml should be changed to enterprise.catalog.app.
| ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160' | |
| ENTERPRISE_CATALOG_URL = 'http://enterprise-catalog.devstack.edx:18160' |
|
|
||
| LMS_URL = 'http://edx.devstack.lms:18000' | ||
| ENTERPRISE_CATALOG_URL = 'http://edx.devstack.enterprise-catalog:18160' | ||
| ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160' |
There was a problem hiding this comment.
The hostname enterprise.catalog.app in the URL does not match the container name enterprise.catalog.app from docker-compose.yml, which uses hostname enterprise-catalog.devstack.edx (line 746). This mismatch will cause connection failures. The URL should use http://enterprise-catalog.devstack.edx:18160 to match the actual hostname, or the hostname in docker-compose.yml should be changed to enterprise.catalog.app.
| ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160' | |
| ENTERPRISE_CATALOG_URL = 'http://enterprise-catalog.devstack.edx:18160' |
| ENTERPRISE_LEARNER_PORTAL_URL = 'http://localhost:8734' | ||
| ENTERPRISE_ADMIN_PORTAL_URL = 'http://localhost:1991' | ||
| ENTERPRISE_CATALOG_URL = 'http://edx.devstack.enterprise-catalog:18160' | ||
| ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160' |
There was a problem hiding this comment.
The hostname enterprise.catalog.app in the URL does not match the container name enterprise.catalog.app from docker-compose.yml, which uses hostname enterprise-catalog.devstack.edx (line 746). This mismatch will cause connection failures. The URL should use http://enterprise-catalog.devstack.edx:18160 to match the actual hostname, or the hostname in docker-compose.yml should be changed to enterprise.catalog.app.
| ENTERPRISE_CATALOG_URL = 'http://enterprise.catalog.app:18160' | |
| ENTERPRISE_CATALOG_URL = 'http://enterprise-catalog.devstack.edx:18160' |
macdiesel
force-pushed
the
bbeggs/change_catalog_name
branch
from
d5768b7 to
8b831bb
Compare
macdiesel
force-pushed
the
bbeggs/change_catalog_name
branch
from
8b831bb to
045be45
Compare
No description provided.