Skip to content

Conversation

@pwnage101
Copy link
Member

@pwnage101 pwnage101 commented Jul 11, 2025

Added 3 MFEs:

  • frontend-app-admin-portal
  • frontend-app-learner-portal-enterprise
  • frontend-app-enterprise-checkout

Also fix bug where enterprise-subsidy was missing from a list, preventing make enterprise-subsidy-logs -esque commands from working.

Added 3 MFEs:

- frontend-app-admin-portal
- frontend-app-learner-portal-enterprise
- frontend-app-enterprise-checkout

Also fix bug where enterprise-subsidy was missing from a list,
preventing `make enterprise-subsidy-logs` type commands from working.
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-10194-0 branch from 52c0b05 to ee2c5b9 Compare July 11, 2025 00:38
Comment on lines +78 to +82
| `frontend-app-admin-portal`_ | http://localhost:1991 | MFE (React.js) | Extra |
+-------------------------------------------+-------------------------------------+----------------+--------------+
| `frontend-app-learner-portal-enterprise`_ | http://localhost:8734 | MFE (React.js) | Extra |
+-------------------------------------------+-------------------------------------+----------------+--------------+
| `frontend-app-enterprise-checkout`_ | http://localhost:1989 | MFE (React.js) | Extra |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only added these 3 rows.

@pwnage101 pwnage101 requested a review from Copilot July 11, 2025 15:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds three new enterprise microfrontends to Devstack and fixes a missing entry for enterprise-subsidy, restoring related make commands.

  • Added frontend-app-admin-portal, frontend-app-learner-portal-enterprise, and frontend-app-enterprise-checkout across repos, configs, docs, and compose files
  • Updated lms.py debug toolbar settings and options.mk to include enterprise-subsidy and the new MFEs
  • Extended docker-compose and docker-compose-host definitions for the three MFEs

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
repo.sh Added three new MFE GitHub URLs to non_release_repos and non_release_ssh_repos
py_configuration_files/lms.py Defined ENTERPRISE_CHECKOUT constants and included in debug toolbar lists
options.mk Appended new MFEs to EDX_SERVICES and added enterprise-subsidy to DB_SERVICES
docs/service_list.rst Added table rows and anchors for the three new MFEs
docker-compose.yml Added service definitions for the new MFEs with ports, aliases, and depends_on
docker-compose-host.yml Mounted host volumes and node_modules for the new MFEs
Comments suppressed due to low confidence (4)

docs/service_list.rst:78

  • After extending the table with new entries, verify that the grid separators (the +/- lines) align with the updated column widths so the table renders correctly in RST.
| `frontend-app-admin-portal`_              | http://localhost:1991               | MFE (React.js) | Extra        |

docker-compose.yml:1219

  • [nitpick] The new microfrontend depends on lms and enterprise-access, but enterprise-subsidy is also required for enterprise checkout flows. Consider adding enterprise-subsidy to the depends_on list.
      - enterprise-access

docs/service_list.rst:126

  • [nitpick] The other microfrontend anchors reference the openedx org, but this anchor points to edx. Double-check that the repository namespace is correct for consistency.
.. _frontend-app-enterprise-checkout: https://github.com/edx/frontend-app-enterprise-checkout

repo.sh:59

  • [nitpick] This clone URL uses the edx GitHub organization, whereas the other microfrontends use openedx. Confirm that the enterprise-checkout repository is intended to live under edx rather than openedx.
    "https://github.com/edx/frontend-app-enterprise-checkout.git"

@pwnage101 pwnage101 merged commit 8cf697c into master Jul 14, 2025
19 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-10194-0 branch July 14, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants