Add pre-render hook#286
Closed
danielhedinn wants to merge 1 commit intoeditor-js:masterfrom
hedinnhf:Add-render-prehook
Closed
Add pre-render hook#286danielhedinn wants to merge 1 commit intoeditor-js:masterfrom hedinnhf:Add-render-prehook
danielhedinn wants to merge 1 commit intoeditor-js:masterfrom
hedinnhf:Add-render-prehook
Conversation
Add pre-render hook
Contributor
|
Take a look at this PR: #253 |
Author
|
I will say I'm rather new to ts development, so I may know about potential best/worst practices related to this matter - And I may be biased. But to be frank, I don't care which implementation you go with, I just want to see this feature in the module :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional configuration field where you can pass function that is run before the image is rendered.
An example of the use case of this is if images are uploaded to private s3 buckets (or other places where a signed url is needed to retreive the image).
The "identifier" of the image can be passed as additional data with the url and the pre-render hook can update the signed url.
this PR also closes #241.