Skip to content

🚀 Enhancement: Allow custom message on upload error #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tech-magnety-ai wants to merge 2 commits into
base: master
Choose a base branch
from
Open

🚀 Enhancement: Allow custom message on upload error #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b349ce
Feature: Allow custom message on upload error
emerilek Apr 28, 2024
f3d4972
Custom error message
emerilek May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .yarn/install-state.gz
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
nodeLinker: node-modules
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@editorjs/image",
"version": "2.9.0",
"version": "2.9.1",
"keywords": [
"codex editor",
"image",
Expand Down Expand Up @@ -47,4 +47,4 @@
"dependencies": {
"@codexteam/icons": "^0.0.6"
}
}
}
8 changes: 5 additions & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ export default class ImageTool {
if (response.success && response.file) {
this.image = response.file;
} else {
this.uploadingFailed('incorrect response: ' + JSON.stringify(response));
const customErrorMessage = typeof response.message === 'string' ? response.message : undefined;
this.uploadingFailed('incorrect response: ' + JSON.stringify(response), customErrorMessage);
}
}

Expand All @@ -408,13 +409,14 @@ export default class ImageTool {
*
* @private
* @param {string} errorText - uploading error text
* @param {string | undefined} customErrorText - displayed error text
* @returns {void}
*/
uploadingFailed(errorText) {
uploadingFailed(errorText, customErrorText) {
console.log('Image Tool: uploading failed because of', errorText);

this.api.notifier.show({
message: this.api.i18n.t('Couldn’t upload image. Please try another.'),
message: customErrorText ?? this.api.i18n.t('Couldn’t upload image. Please try another.'),
style: 'error',
});
this.ui.hidePreloader();
Expand Down
Loading