fix: prevent balance-windows from resizing chat window#205
fix: prevent balance-windows from resizing chat window#205ericdallo merged 1 commit intoeditor-code-assistant:masterfrom
balance-windows from resizing chat window#205Conversation
As title, without this change, when running `balance-windows`, even if eca-chat window is a side window, it will try to balance it. An alternative is to not use side window, but the implication then is, your chat constantly is resized when opening/closing buffers. With this fix, your side window size is respected regardless of other buffers/windows.
balance-windows from resizing chatbalance-windows from resizing chat window
ericdallo
left a comment
There was a problem hiding this comment.
I don't see any harm, looks good, thank you!
|
@sata Actually I reverted that after relaizing this blocks user from change chat size even for when on side window (I myself use this all the time via |
@ericdallo Ah! I didn't use that, but I see it doesn't work. This works for me. Essentially wrapping a advice around I'll give this a go for a few days and see how I get on. Became more complicated than I thought and also I'm not a huge fan of messing around with advices for general use. Perhaps there is a better way to do it 'as a standard' -- thought as a side window, it just doesn't seem right how |
Without this change, when running
balance-windows, even if eca-chat window is a side window, it will try to balance it.An alternative is to not use side window, but the implication then is, your chat constantly is resized when opening/closing buffers and running
balance-windowsWith this fix, your side window size is respected regardless of other buffers/windows.
Relates to #126
I'm not really a elisp coder, so I'm up for any changes to the few lines this change consist of.
Current version
After applying patch