extract optional and required SGX claims provided by Open Enclave#233
Open
THS-on wants to merge 1 commit intoedgelesssys:masterfrom
Open
extract optional and required SGX claims provided by Open Enclave#233THS-on wants to merge 1 commit intoedgelesssys:masterfrom
THS-on wants to merge 1 commit intoedgelesssys:masterfrom
Conversation
✅ Deploy Preview for ego-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
Member
|
Thank you for wanting to contribute to EGo! The feature makes sense and we would like to accept it. I haven't reviewed the implementation in detail yet. You need to sign the CLA (see above) so that we can accept your contribution. |
Author
|
I need to check, if I can sign the CLA. This might take longer time. Is it possible to contribute changes without the CLA? |
Member
|
No, unfortunately not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the extraction of all the optional and required SGX claims provided by Open Enclave.
The main motivation was to get the UEID which matches the QEID, so that it is possible to tie the quote and machine where the enclave is running on together. The additional information gives more flexibility to attest the system.
Changes around the Report struct:
Two new structs SGXOptional and SGXRequired are introduced to hold the respective claims.