fix(compaction): add immediate_compaction option, default false#1913
Closed
fix(compaction): add immediate_compaction option, default false#1913
Conversation
Theodus
force-pushed
the
theodus/compaction
branch
from
1767267 to
91a008e
Compare
When immediate_compaction is false (the new default), segments within the cooldown period cannot be compacted. This prevents compaction from locking in data from an orphaned blockchain fork before a reorg settles. Previously, "hot" segments (within cooldown) could still compact with same-generation segments, which could mix finalized and non-finalized blocks and create fragmentation that adds dignificant delays to reorg resolution.
Theodus
force-pushed
the
theodus/compaction
branch
from
f9fe099 to
e096d6b
Compare
Member
Author
|
Replaced by #1932 |
Theodus
added a commit
that referenced
this pull request
Mar 6, 2026
This a proposal to simplify the compaction algorithm into essentially:
- Iterate over the canonical chain in order.
- If a file that is not under cooldown is found, start a compaction group.
- Add files to that group until the target would be exceeded.
Generation-based compaction for files under cooldown is removed. Eager compaction configuration for recent files is simplified to be purely generation based, replacing the more complex `eager_compaction_limit`.
Replaces #1417, #1913
---------
Signed-off-by: Theo Butler <theodusbutler@gmail.com>
Co-authored-by: Leonardo Yvens <leoyvens@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When immediate_compaction is false (the new default), segments within the cooldown period cannot be compacted. This prevents compaction from locking in data from an orphaned blockchain fork before a reorg settles.
Previously, "hot" segments (within cooldown) could still compact with same-generation segments, which could mix finalized and non-finalized blocks and create fragmentation that adds dignificant delays to reorg resolution.