[nbrshow] Prevent crash when FDB entries are missing or aged out#117
Merged
gord1306 merged 1 commit intoAug 29, 2025
Merged
Conversation
Why I did it When excessive MAC addresses are learned and MAC aging occurs, pre-fetched keys may become out of sync with the actual ASIC_DB state, causing nbrshow or show arp to terminate unexpectedly. What I did Disable blocking on get_all() to avoid repeated retries. Add try-except to prevent nbrshow termination on database access failure. Add checks for required keys in FDB entries to avoid KeyError. How I verified it Run nbrshow -4/-6 or show arp on DUT with many MACs and aging events: command completes successfully. Problematic FDB entries are skipped; valid neighbors are displayed. ARP/neighbor pytest tests pass.
Author
|
Hi @gord1306 , Please help review it, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When excessive MAC addresses are learned and MAC aging occurs, pre-fetched keys may become out of sync with the actual ASIC_DB state, causing nbrshow or show arp to terminate unexpectedly.
What I did
Disable blocking on get_all() to avoid repeated retries. Add try-except to prevent nbrshow termination on database access failure. Add checks for required keys in FDB entries to avoid KeyError.
How I verified it
Run nbrshow -4/-6 or show arp on DUT with many MACs and aging events: command completes successfully. Problematic FDB entries are skipped; valid neighbors are displayed. ARP/neighbor pytest tests pass.