clk-baikal: initialize clock early enough, and memory allocation fixes#3
Open
asheplyakov wants to merge 4 commits intoedelweiss-tech:linux-5.4-tpfrom
Open
clk-baikal: initialize clock early enough, and memory allocation fixes#3asheplyakov wants to merge 4 commits intoedelweiss-tech:linux-5.4-tpfrom
asheplyakov wants to merge 4 commits intoedelweiss-tech:linux-5.4-tpfrom
Conversation
Currently clk-baikal gets initialized very late (after staring secondary CPUs, PCI-e init, etc). This is wrong: the clock driver should be initialized very early. Use CLK_OF_DECLARE_DRIVER to ensure clk-baikal initializes early enough (like a clock driver should).
Allocate (and zero initialize) memory for baikal_clk_cmu structure (instead of a *pointer* to that structure).
Avoid NULL dereference on (very unlikely) memory allocation failure. Note: this patch misses proper cleanup, however the thing is going to panic() on clock initialization failure anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently clk-baikal gets initialized very late (after starting secondary CPUs, PCI-e init, etc).
This is wrong: clock driver should initialized much earlier. Use CLK_OF_DECLARE_DRIVER
to ensure clock gets initialized/registered early enough
dmesg before:
dmesg with patch: