Open
Conversation
e7ed8dc to
4249573
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #251 +/- ##
===========================================
+ Coverage 56.30% 56.32% +0.01%
===========================================
Files 321 323 +2
Lines 21177 21118 -59
Branches 1684 1686 +2
===========================================
- Hits 11924 11894 -30
+ Misses 9253 9224 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prefix all misc keys and add `dumpUnscopedRecord` method
Access new keys through records to apply checks and defaults
Rename missingValue -> misc-missingValue
Also default bitmapPresent to false instead of allowing it to be unset
4249573 to
4b03c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New prefixed (with
misc-) keys should be used inscale,statistics-mtg2andencode-mtg2actions.If you review this PR, I suggest going commit by commit.
The main changes in this PR:
misc-in their definitionMiscRecordcan be dumped without thismisc-prefix, this is needed in theencode-mtg2actionstatistics-mtg2actionstatistics-mtg2action to enable the proper parsing/defaulting upon readingSome improvements that we should discuss + my opinion:
statistics-mtg2action, this should be refactored further to access everything through the recordstatistics-mtg2, it should be parsed once and then passed aroundFullMarsRecordandMiscRecordare defined outside theencode-mtg2action, but to my knowledge only used there, we should define the records in that action header insteadFlushKindenum is not really astatistics-mtg2specific thing, it should be movedserverRankandrestartDateTimekeysMarsMiscGeo.hnow contains some random keys which are not mars, nor grib, perhaps we should create a new fileMultioKeys.h?We should checkImplemented for scale and average-rate actionsmisc-bitmapPresentbefore readingmisc-missingValueDefaulted bitmapPresent to falsemisc-bitmapPresentandmisc-missingValuedon't have default values, this is especially confusing for the bitmapPresent. It can now be optional, and it is unclear if that means the bitmap is present or not. I should either be a required key, or defaulted to true/false.🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-251