Skip to content

Implement encoding for currently known CAMS fields#184

Open
tweska wants to merge 4 commits intodevelopfrom
feature/mars2grib-chem
Open

Implement encoding for currently known CAMS fields#184
tweska wants to merge 4 commits intodevelopfrom
feature/mars2grib-chem

Conversation

@tweska
Copy link
Copy Markdown
Member

@tweska tweska commented Mar 17, 2026

This PR implements encoding for fields mapped in ecmwf/multio#245

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 10.71429% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.27%. Comparing base (03c7e0f) to head (e5774b6).

Files with missing lines Patch % Lines
...kit/mars2grib/backend/deductions/firstWavelength.h 0.00% 8 Missing ⚠️
...backend/concepts/composition/compositionEncoding.h 0.00% 6 Missing ⚠️
.../backend/concepts/composition/compositionMatcher.h 37.50% 5 Missing ⚠️
src/metkit/mars2grib/backend/deductions/chemId.h 0.00% 4 Missing ⚠️
...it/mars2grib/backend/concepts/level/levelMatcher.h 0.00% 1 Missing ⚠️
...ackend/concepts/point-in-time/pointInTimeMatcher.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #184      +/-   ##
===========================================
- Coverage    62.33%   62.27%   -0.07%     
===========================================
  Files          303      304       +1     
  Lines        11601    11615      +14     
  Branches      1036     1035       -1     
===========================================
+ Hits          7232     7233       +1     
- Misses        4369     4382      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tweska tweska marked this pull request as draft March 18, 2026 12:26
@tweska
Copy link
Copy Markdown
Member Author

tweska commented Mar 18, 2026

I seem to have broken something with this PR. I'll keep this as draft until I figure out what.

It was a ) in the wrong position... :^/

@tweska tweska force-pushed the feature/mars2grib-chem branch from ab4868e to 4143b4c Compare March 18, 2026 16:25
@tweska tweska marked this pull request as ready for review March 18, 2026 16:40
@tweska tweska force-pushed the feature/mars2grib-chem branch 2 times, most recently from 1c91323 to 423d1a2 Compare March 20, 2026 09:31
@tweska tweska force-pushed the feature/mars2grib-chem branch from a4f4e35 to 544403b Compare March 30, 2026 09:56
@tweska tweska force-pushed the feature/mars2grib-chem branch from 544403b to e5774b6 Compare March 30, 2026 10:01
@MircoValentiniECMWF
Copy link
Copy Markdown
Contributor

Now seems ok. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants