Skip to content

Refactoring name validity#310

Merged
marcosbento merged 2 commits intodevelopfrom
feat/refactoring
Mar 30, 2026
Merged

Refactoring name validity#310
marcosbento merged 2 commits intodevelopfrom
feat/refactoring

Conversation

@marcosbento
Copy link
Copy Markdown
Collaborator

@marcosbento marcosbento commented Mar 28, 2026

Description

Refactoring name validity, This improves runtime performance and also clarifies the error message.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-310

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.63%. Comparing base (b8b9e22) to head (af41988).

Files with missing lines Patch % Lines
libs/node/src/ecflow/node/AvisoAttr.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #310   +/-   ##
========================================
  Coverage    49.62%   49.63%           
========================================
  Files         1237     1238    +1     
  Lines        97536    97542    +6     
  Branches     14828    14833    +5     
========================================
+ Hits         48407    48414    +7     
+ Misses       49129    49128    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento merged commit af41988 into develop Mar 30, 2026
137 checks passed
@marcosbento marcosbento deleted the feat/refactoring branch March 30, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants