Skip to content

Several refactoring items#308

Merged
marcosbento merged 15 commits intodevelopfrom
improv/reserve_16
Mar 27, 2026
Merged

Several refactoring items#308
marcosbento merged 15 commits intodevelopfrom
improv/reserve_16

Conversation

@marcosbento
Copy link
Copy Markdown
Collaborator

@marcosbento marcosbento commented Mar 26, 2026

Description

Several refactoring items

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-308

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 80.68966% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.63%. Comparing base (cb5f79b) to head (3d813a1).

Files with missing lines Patch % Lines
libs/test/overall/harness/TestFixture.cpp 0.00% 6 Missing ⚠️
libs/client/test/harness/SCPort.cpp 40.00% 3 Missing ⚠️
libs/base/src/ecflow/base/Gnuplot.cpp 0.00% 2 Missing ⚠️
libs/client/test/TestPlugCmd.cpp 0.00% 2 Missing ⚠️
libs/core/src/ecflow/core/LogVerification.cpp 0.00% 2 Missing ⚠️
libs/core/test/TestStr.cpp 0.00% 2 Missing ⚠️
libs/node/src/ecflow/node/ExprAst.cpp 0.00% 2 Missing ⚠️
libs/node/src/ecflow/node/InLimitMgr.cpp 33.33% 2 Missing ⚠️
libs/node/src/ecflow/node/Node.cpp 77.77% 2 Missing ⚠️
libs/test/overall/TestTrigger.cpp 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #308      +/-   ##
===========================================
- Coverage    49.68%   49.63%   -0.05%     
===========================================
  Files         1237     1237              
  Lines        97636    97536     -100     
  Branches     14829    14828       -1     
===========================================
- Hits         48507    48412      -95     
+ Misses       49129    49124       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento marked this pull request as ready for review March 27, 2026 09:30
@marcosbento marcosbento merged commit b8b9e22 into develop Mar 27, 2026
265 of 266 checks passed
@marcosbento marcosbento deleted the improv/reserve_16 branch March 27, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants