[DRAFT] Remove redundant adjoint GPU communication routines#342
[DRAFT] Remove redundant adjoint GPU communication routines#342samhatfield wants to merge 10 commits intodevelopfrom
Conversation
ee9a97f to
8e42ca4
Compare
268c21a to
f995241
Compare
|
Any thoughts on this @l90lpa? I was hoping I could also delete |
|
Hi @samhatfield, sorry for the slow reply. Yes, I had originally wanted to take the approach you're discussing, however, the issue I ran into was that |
This reverts commit f261ee1b437539f5f419a06dc89904cb91fe3f60.
f995241 to
452d1d3
Compare
In the CPU code path, we don't have "AD" versions for
TRLTOG,TRLTOMetc. Instead we simply use the inverse routine (e.g. G->L instead of L->G) with the input / output arguments swapped. In the GPU code path though we have additional subroutinesTRLTOMADandTRMTOLAD. This PR is for investigating whether these routines can be eliminated. If this succeeds, then we can close PR #340 unmerged.