Skip to content

Add amdflang to CI#248

Open
samhatfield wants to merge 24 commits intodevelopfrom
add_amd-flang
Open

Add amdflang to CI#248
samhatfield wants to merge 24 commits intodevelopfrom
add_amd-flang

Conversation

@samhatfield
Copy link
Copy Markdown
Collaborator

No description provided.

@samhatfield samhatfield force-pushed the add_amd-flang branch 3 times, most recently from f9d311f to ef22e1a Compare April 2, 2025 08:52
@samhatfield samhatfield added enhancement New feature or request actions labels Apr 2, 2025
@samhatfield samhatfield force-pushed the add_amd-flang branch 10 times, most recently from bde3d37 to 9494959 Compare April 2, 2025 17:27
@samhatfield
Copy link
Copy Markdown
Collaborator Author

samhatfield commented Apr 3, 2025

Status:

  • MPI has been disabled for amdflang. Somehow the OpenMPI built by amdflang can't be found by CMake. We will work on this in a future PR.
  • Otherwise all tests are passing with amdflang except for ectrans_test_install which segfaults when running transi_sptogp. This is very similar to what we saw with IntelLLVM actually, which is very suspicious. However I cannot yet debug this crash interactively as I can't build a working amdflang on ECMWF's systems (I could probably build amdflang on my Mac but I have a feeling it's OS-specific). Will liaise with @PaulMullowney about how to debug this further. - Edit: now working by setting stack size to unlimited.

@samhatfield samhatfield force-pushed the add_amd-flang branch 4 times, most recently from 39317d6 to bf23883 Compare April 4, 2025 12:38
@samhatfield samhatfield requested a review from wdeconinck April 4, 2025 12:39
@samhatfield
Copy link
Copy Markdown
Collaborator Author

Note #249 must be merged into this in order for the amdflang tests to pass.

Copy link
Copy Markdown
Collaborator

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks also for the install-amd-flang script. Very useful.

@marsdeno
Copy link
Copy Markdown
Collaborator

Excellent!

@PaulMullowney
Copy link
Copy Markdown
Contributor

We should hook the GPU build in, next. It will runtime fail, but at least we'll be covering compilation.

@samhatfield
Copy link
Copy Markdown
Collaborator Author

Note #249 must be merged into this in order for the amdflang tests to pass.

Correction: #249 must be merged into this in order for the amdflang tests to run. In this branch the TESTS feature is disabled for amdflang because we are building without MPI. After #249 is merged to develop (and I rebase this branch) we will be able to enable TESTS without MPI and we can then check whether the test suite passes for amdflang.

@wdeconinck
Copy link
Copy Markdown
Collaborator

Let's merge #249 first regardless

@samhatfield
Copy link
Copy Markdown
Collaborator Author

I'll try upgrading to amdflang 22.2.0 first, then adding -fno-stack-arrays.

@samhatfield samhatfield force-pushed the add_amd-flang branch 3 times, most recently from 63ea3bf to d778227 Compare January 26, 2026 17:15
@samhatfield
Copy link
Copy Markdown
Collaborator Author

Now compiling with -fno-stack-arrays. Still doesn't work :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants